Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @steal in slim build #849

Closed
matthewp opened this issue Sep 22, 2017 · 1 comment
Closed

Support @steal in slim build #849

matthewp opened this issue Sep 22, 2017 · 1 comment
Assignees

Comments

@matthewp
Copy link
Member

@imaustink commented on Fri Sep 22 2017

Potentially unhandled rejection [1] Error: Cannot create slim build. "@steal" module is not supported
    at isAtSteal (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/steal-tools/lib/slim/checks/steal.js:32:9)
    at Array.forEach (<anonymous>)
    at /Users/austinkurpuis/bitovi/bitcentive/public/node_modules/steal-tools/lib/slim/checks/steal.js:21:21
    at Array.forEach (<anonymous>)
    at module.exports (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/steal-tools/lib/slim/checks/steal.js:10:14)
    at checkSupport (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/steal-tools/lib/stream/check_slim_support.js:20:2)
    at DestroyableTransform._transform (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/steal-tools/lib/stream/check_slim_support.js:10:15)
    at DestroyableTransform.Transform._read (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/readable-stream/lib/_stream_transform.js:182:10)
    at DestroyableTransform.Transform._write (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/readable-stream/lib/_stream_transform.js:170:83)
    at doWrite (/Users/austinkurpuis/bitovi/bitcentive/public/node_modules/readable-stream/lib/_stream_writable.js:406:64)

This is preventing Bitcentive from taking advantage of the slim build, as many of its dependencies, for example, steal-socket.io, use @steal.


@imaustink commented on Fri Sep 22 2017

cc @matthewp @m-mujica

@matthewp
Copy link
Member Author

Simple implementation would be:

steal = {};
steal.loader = require("@loader");
steal.done = Promise.resolve();

As a start at least, that accounts for most usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants