Merge pull request #498 from johanneswuerbach/error-unacked-on-close

Error pending confirmation callbacks on channel close

.npmignore

@@ -4,6 +4,5 @@ scratch
 # node_modules is ignored anyway
 .travis.yml
 bin/amqp-rabbitmq-0.9.1.json
-bin/generate-defs.js
 etc/
 coverage/

lib/channel.js

@@ -33,6 +33,12 @@ function Channel(connection) {
   this.on('nack', this.handleConfirm.bind(this, function(cb) {
     if (cb) cb(new Error('message nacked'));
   }));
+  this.on('close', function () {
+    var cb;
+    while (cb = this.unconfirmed.shift()) {
+      if (cb) cb(new Error('channel closed'));
+    }
+  })
   // message frame state machine
   this.handleMessage = acceptDeliveryOrReturn;
 }

package.json

@@ -27,7 +27,7 @@
   },
   "scripts": {
     "test": "make test",
-    "prepublish": "make"
+    "prepare": "make"
   },
   "keywords": [
     "AMQP",

test/channel_api.js

@@ -581,4 +581,17 @@ confirmtest('wait for confirms', function(ch) {
   return ch.waitForConfirms();
 })
 
+confirmtest('works when channel is closed', function(ch) {
+  for (var i=0; i < 1000; i++) {
+    ch.publish('', '', Buffer.from('foobar'), {});
+  }
+  return ch.close().then(function () {
+    return ch.waitForConfirms()
+  }).then(function () {
+    assert.strictEqual(true, false, 'Wait should have failed.')
+  }, function (e) {
+    assert.strictEqual(e.message, 'channel closed')
+  });
+});
+
 });