fix: add tests for missing package name

.gitignore

@@ -7,3 +7,4 @@ local.log
 tmp
 .DS_Store
 package-lock.json
+!**/package-lock.json

src/lib/snyk-test/npm/index.js

@@ -75,11 +75,6 @@ function test(root, options) {
               return pkg;
             });
         }).then((pkg) => {
-          // if there's no package name, let's get it from the root dir
-          if (!pkg.name) {
-            pkg.name = path.basename(path.resolve(root));
-          }
-
           policyLocations = policyLocations.concat(pluckPolicies(pkg));
           debug('policies found', policyLocations);
           analytics.add('policies', policyLocations.length);

test/acceptance/cli.acceptance.test.js

@@ -1815,6 +1815,30 @@ test('`monitor non-existing`', function (t) {
   });
 });
 
+test('monitor for package with no name', function (t) {
+  t.plan(1);
+  return cli.monitor({
+    file: __dirname + '/../fixtures/package-sans-name/package.json',
+  })
+    .then(function () {
+      t.pass('succeed');
+    }).catch(function (e) {
+      t.fail('Failed with: ' + e.message);
+    });
+});
+
+test('monitor for package with no name in lockfile', function (t) {
+  t.plan(1);
+  return cli.monitor({
+    file: __dirname + '/../fixtures/package-sans-name-lockfile/package-lock.json',
+  })
+    .then(function () {
+      t.pass('succeed');
+    }).catch(function (e) {
+      t.fail('Failed with: ' + e.message);
+    });
+});
+
 test('`monitor npm-package`', function (t) {
   chdirWorkspaces();
   return cli.monitor('npm-package')

test/fixtures/package-sans-name-lockfile/package.json

@@ -0,0 +1,12 @@
+{
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "ISC",
+  "dependencies": {
+    "semver": "^2.3.2"
+  }
+}

test/package-no-name.test.js

@@ -8,4 +8,13 @@ test('packages with no name read dir', function (t) {
   }).catch(function (e) {
     t.fail('Failed with: ' + e.message);
   });
-});
+});
+
+test('packages with no name read dir with a lockfile', function (t) {
+  t.plan(1);
+  snyk.test(__dirname + '/fixtures/package-sans-name-lockfile').then(function () {
+    t.pass('succeed');
+  }).catch(function (e) {
+    t.fail('Failed with: ' + e.message);
+  });
+});