Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test and ParsedQuery TypeScript type #170

Merged
merged 2 commits into from Mar 14, 2019

Conversation

sn42
Copy link
Contributor

@sn42 sn42 commented Mar 9, 2019

  • Fixes the failing test should sort keys in given order of the stringify function. The test's sort function didn't result in the specified order (expected: c=baz&a=foo&b=bar, actual: a=foo&b=bar&c=baz).
  • Fixes the ParsedQuery type. Values may be null as seen here.

@sindresorhus sindresorhus changed the title Fix failing test and ParsedQuery type Fix failing test and ParsedQuery TypeScript type Mar 14, 2019
@sindresorhus sindresorhus merged commit 49d2203 into sindresorhus:master Mar 14, 2019
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants