Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass error thrown in the init hook to beforeError hook #929

Closed
szmarczak opened this issue Nov 14, 2019 · 0 comments · Fixed by #1051
Closed

Pass error thrown in the init hook to beforeError hook #929

szmarczak opened this issue Nov 14, 2019 · 0 comments · Fixed by #1051
Labels
enhancement This change will extend Got features ✭ help wanted ✭

Comments

@szmarczak
Copy link
Collaborator

Currently that's not possible, the init hook is called by normalizeArguments, which is catched directly by the Got promise.
@szmarczak szmarczak added enhancement This change will extend Got features ✭ help wanted ✭ labels Nov 14, 2019
@szmarczak szmarczak mentioned this issue Feb 6, 2020
Merged
18 tasks
szmarczak added a commit to szmarczak/got that referenced this issue Feb 29, 2020
@szmarczak
fix sindresorhus#929
2d46361
szmarczak added a commit to szmarczak/got that referenced this issue Mar 3, 2020
@szmarczak
fix sindresorhus#929
994152b
szmarczak added a commit to szmarczak/got that referenced this issue Mar 4, 2020
@szmarczak
fix sindresorhus#929
4fbf4b9
@snyk-bot snyk-bot mentioned this issue Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This change will extend Got features ✭ help wanted ✭
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite Got szmarczak/got
1 participant
@szmarczak