Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pushd/popd -q option #753

Closed
nfischer opened this issue Jul 25, 2017 · 3 comments
Closed

Feature request: pushd/popd -q option #753

nfischer opened this issue Jul 25, 2017 · 3 comments

Comments

@nfischer
Copy link
Member

Originally suggested in this comment by @MattSturgeon

We might consider implementing the -q option (it's available in zsh, not in bash) for pushd/popd. this option does some zsh-specific things (i.e. the mention of $chpwd_functions), but it also suppresses console output.

In ShellJS, we would only want this to suppress console output (ignore the $chwd_functions stuff).

@alexreg
Copy link
Contributor

alexreg commented Oct 3, 2017

Any progress on this lately? Or a workaround even?

@nfischer
Copy link
Member Author

nfischer commented Oct 3, 2017

A PR would be welcome (and probably not very difficult). We only call common.log() here and here. All that's needed is a little bit of plumbing to pass command options to _dirs().


Workaround:

shell.config.silent = true;
shell.pushd(...);
shell.config.silent = false;

@nfischer
Copy link
Member Author

Fixed in #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants