Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up common tests #714

Closed
freitagbr opened this issue May 3, 2017 · 0 comments
Closed

Clean up common tests #714

freitagbr opened this issue May 3, 2017 · 0 comments
Assignees
@freitagbr
Labels
low priority test

Comments

@freitagbr
Copy link
Contributor

Some of the tests in test/common.js make the check t.falsy(shell.error()). This is not necessary, because these methods will not actually set the shell error.
@freitagbr freitagbr self-assigned this May 3, 2017
@freitagbr freitagbr mentioned this issue Oct 13, 2017
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
@snyk-bot snyk-bot mentioned this issue Aug 13, 2019
Open
This was referenced Aug 29, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 19, 2019
Open
@snyk-bot snyk-bot mentioned this issue Nov 29, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
This was referenced Mar 24, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Open
This was referenced Apr 24, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freitagbr freitagbr

Labels
low priority test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freitagbr