Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for v0.12 #647

Closed
nfischer opened this issue Jan 16, 2017 · 2 comments
Closed

Drop support for v0.12 #647

nfischer opened this issue Jan 16, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@nfischer
Copy link
Member

According to the NodeJS LTS schedule, v0.12 support was dropped by Node in December 2016. This means it's probably reasonable to drop the support in our v0.8 release.

This has some benefits for us:

  • we can cut v0.11 and v0.12 from our Travis builds for faster CI (maybe even iojs too, which sometimes has false negatives)
  • we can significantly trim down on the code inside src/exec.js (there's a whole v0.10-specific else-branch)
  • we can clean up tests
  • we can trim down src/tempdir.js a bit as well
  • we can remove our Object.assign() polyfill (if we remove iojs as well)

@freitagbr what are your thoughts on dropping v0.12 support? What about dropping iojs support? We'll get the biggest CI benefits if we go with iojs, but I don't know if many people still rely on it (my guess is iojs users have moved on to v4+).

@nfischer nfischer added this to the v0.8.0 milestone Jan 16, 2017
@freitagbr
Copy link
Contributor

I would be in favor of dropping support for iojs. I don't see it being widely used in production or even development, and like you said, most iojs users should at least be on v4 or later by now.

I know usage of v0.12 is pretty common still, though dropping support for v0.12 and below is probably fine as long as this lands in v0.8+ only.

Just make sure that "engines": { "node": ">=4" } ends up in package.json.

@nfischer
Copy link
Member Author

Ok, I can take this up

@nfischer nfischer assigned nfischer and unassigned freitagbr Jan 17, 2017
nfischer added a commit that referenced this issue Jan 17, 2017
nfischer added a commit that referenced this issue Jan 17, 2017
nfischer added a commit that referenced this issue Jan 18, 2017
freitagbr pushed a commit that referenced this issue Jun 7, 2017
nfischer added a commit that referenced this issue Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants