Fix handling of stage specific setting for split stacks case #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirm on deployment not just Rest API
Uncoditionally search for Rest API if `http` events are configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In setup where resources are distributed into nested stacks, API Gateway resource may not be present in main stack.
With #7663 we've changed behavior, and assume there's no API Gateway if it doesn't appear in main stack. Still it broke for services relying on e.g.
serverless-plugin-split-stacksplugin.This patch ensures that if there are
httpevents configured we unconditionally attempt to find the Rest API Id and it's deployment.Additionally improved configuration check to be based on deployment id and not just rest API id (if there's no deployment, then we're also incapable on applying any stage settings)