Updating stream event properties "MaximumRetryAttempts" & "BisectBatchOnFunctionError" when value is falsy. #7682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updating property "maximumRetryAttempts" when set to 0.
medikoo
suggested changes
May 6, 2020
There was a problem hiding this comment.
@jagdeep-singh great thanks for that fix!
I'll be happy to take it in, just please see my suggestions.
This reverts commit e1be674.
medikoo
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix below minor bug in event stream mapping.
Issues it will resolve
In the event of stream if i want to specify
maximumRetryAttemptsto0then i can't due to falsy condition of 0 in code. AndOnce i set
bisectBatchOnFunctionErrortotrueand again if i want to make itfalsethen i am not able to do that due to falsy condition of the code.When this merge request will be approved then we will able to define mapping of stream event
maximumRetryAttemptsandbisectBatchOnFunctionErrorto0andfalserespectively.Is this ready for review?: Yes
Is it a breaking change?: NO