Remove variable syntax regex character ranges #7431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
Closes #6559 and #6997. Expand regex for variable syntax by removing fixed character ranges thus allowing non ascii characters as valid fallback values.
How can we verify it
Checkout to
dea5ecc2a0406bc46eb38f6cb8dfc17363d90498
and runlib/classes/Variables.test.js::fallback
andlib/plugins/print/print.test.js::should resolve fallback
tests. Both should fail. Checkout to HEAD, tests should pass.Given a
serverless.yml
With
hello
content:When invoking it should return resolved values.
Todos
Is this ready for review?: YES
Is it a breaking change?: It should be backward compatible so no.