Fix #7149 <WSS> Use AWS partition pseudo param

[austinjalexander]

What did you implement?

During compileApi, the websockets AWS policy generated currently assumes the standard 'aws' partition (see here). This PR replaces 'aws' with the AWS::Partition pseudo parameter.

Closes #7149

How can we verify it?

A new websockets service using a non-standard region; for example:

service: api
frameworkVersion: '>=1.28.0 <2.0.0'

provider:
  name: aws
  runtime: go1.x

  stage: production
  region: us-gov-west-1
...

Will result in something like the following error:

Serverless: Packaging service...
Serverless: Excluding development dependencies...
...
CloudFormation - UPDATE_IN_PROGRESS - AWS::IAM::Role - IamRoleLambdaExecution
CloudFormation - UPDATE_FAILED - AWS::IAM::Role - IamRoleLambdaExecution
...
Serverless: Operation failed!
...
An error occurred: IamRoleLambdaExecution - Partition "aws" is not valid for resource "arn:aws:execute-api:*:*:*/@connections/*". (Service: AmazonIdentityManagement; Status Code: 400; Error Code: MalformedPolicyDocument...
...

Using the changes in this PR, while deploying in a non-standard partition (e.g., 'aws-us-gov'), will result in success! :)

Prior Art

• Remove hard-coded AWS partitions #7175

Resources

• AWS::Partition

Todos

• Write and run all tests
• Write documentation
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

[austinjalexander]

@medikoo It looks like Travis errored out; would you mind re-running, please?

[medikoo]

@austinjalexander thanks for update. It looks way better!

Concerning CI fails, it looks that npm went nuts (issue we didn't see before got exposed).

To have that fixed I needed to update our CI configuration in master, therefore when you update your branch with master issue will be resolved.

[austinjalexander]

Fantastic! Thank you, @medikoo! 😄

[medikoo]

@austinjalexander I've updated your branch automatically with master, and still one CI issue got exposed.
Can you ensure changes follow Prettier formatting? You can easily fix it by running npm run prettify:updated

[codecov-io]

Codecov Report

Merging #7430 into master will decrease coverage by 0.02%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##           master    #7430      +/-   ##
==========================================
- Coverage   87.99%   87.96%   -0.03%     
==========================================
  Files         240      240              
  Lines        9052     9101      +49     
==========================================
+ Hits         7965     8006      +41     
- Misses       1087     1095       +8

Impacted Files	Coverage Δ
lib/classes/Service.js	97.43% <ø> (ø)	⬆️
commitlint.config.js	0% <ø> (ø)	⬆️
lib/plugins/print/print.js	98.5% <ø> (ø)	⬆️
...s/aws/package/compile/events/websockets/lib/api.js	100% <ø> (ø)	⬆️
...esources/resources/cognitoUserPool/lib/userPool.js	0% <0%> (ø)	⬆️
lib/plugins/aws/lib/naming.js	97.41% <100%> (+0.01%)	⬆️
lib/plugins/aws/provider/awsProvider.js	92.72% <80%> (-0.51%)	⬇️
...lugins/aws/package/compile/events/httpApi/index.js	88.6% <90.9%> (+0.17%)	⬆️
lib/plugins/aws/package/compile/functions/index.js	96.71% <91.3%> (-1.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0a0e2...f31cbfa. Read the comment docs.

[austinjalexander]

@medikoo All set! :)

[medikoo]

Thank you @austinjalexander !

[austinjalexander]

Thank you for taking such swift action, @medikoo!