HTTP API: CORS configuration #7336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7336 +/- ##
==========================================
+ Coverage 87.92% 87.96% +0.03%
==========================================
Files 240 240
Lines 8898 8925 +27
==========================================
+ Hits 7824 7851 +27
Misses 1074 1074
Continue to review full report at Codecov.
|
medikoo
force-pushed
the
0213-http-api-cors
branch
from
a33d75b
to
92f4511
Compare
medikoo
force-pushed
the
0213-http-api-cors
branch
from
92f4511
to
07ac90a
Compare
pmuens
previously approved these changes
Feb 14, 2020
| @@ -46,9 +46,13 @@ describe('HttpApiEvents', () => { | |||
|
|
|||
| it('Should not configure default route', () => { | |||
| const resource = cfResources[naming.getHttpApiLogicalId()]; | |||
| expect(resource.Properties).to.not.have.property('RputeKey'); | |||
medikoo
force-pushed
the
0213-http-api-cors
branch
from
53d1027
to
3083970
Compare
medikoo
force-pushed
the
0213-http-api-cors
branch
from
3083970
to
5818494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses another implementation step as outlined at: #7052