-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Limited permission for authorizers #7300
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7300 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 239 239
Lines 8833 8833
=======================================
Hits 7784 7784
Misses 1049 1049
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmuens thanks for looking into that. Looks great to me!
Thanks for the review @medikoo 👍 I rebased the branch so that it's in sync with
@medikoo do you think this is a breaking change as the permissions are stricter compared to the way we handled it before? |
818214b
to
12f7c29
Compare
If someone relied on it, I don't think it could have been conscious. I wouldn't treat it as breaking change (assuming we don't break resource relations in context of deployed service) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it'll go de-sync again. I think it's fine, if you force merge it after rebasing
Thanks for the review @medikoo 👍 |
What did you implement
Fixes a permission issue when using custom authorizers for API Gateways.
❗️ NOTE: Note entirely sure about the impact, but thus could result in a breaking change... ❗️
How can we verify it
The easiest way would be to run the integration tests. Other than that you could use this service config (provided by @glb):
Todos
Is this ready for review?: NO
Is it a breaking change?: MAYBE