Added azure-nodejs-typescript template. #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
suggested changes
Jan 24, 2020
There was a problem hiding this comment.
Thank you @ncipollina for initiative, We definitely miss that template.
Can you just ensure that no unrelated files are included with this PR, and that prosposed changes follow Prettier formatting (you may ensure that with npm run prettify:updated
lib/plugins/create/templates/aws-csharp/obj/Debug/netcoreapp2.1/aws-csharp.AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
ncipollina
force-pushed
the
feature-azure-nodejs-typescript
branch
2 times, most recently
from
1c3c97c
to
7da03af
Compare
ncipollina
force-pushed
the
feature-azure-nodejs-typescript
branch
from
7da03af
to
42611e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #7252 +/- ##
=========================================
- Coverage 88.14% 88.1% -0.05%
=========================================
Files 236 237 +1
Lines 8641 8649 +8
=========================================
+ Hits 7617 7620 +3
- Misses 1024 1029 +5
Continue to review full report at Codecov.
|
medikoo
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
I added a template for Azure Functions using NodeJS and Typescript. It is similar to the AWS lambda version that utilizes webpack for building and deploying the function to Azure.
Closes #7251
How can we verify it
npm run testTodos
Useful Scripts
npm run test:ci--> Run all validation checks on proposed changesnpm run lint:updated--> Lint all the updated filesnpm run lint:fix--> Automatically fix lint problems (if possible)npm run prettier-check:updated--> Check if updated files adhere to Prettier confignpm run prettify:updated--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: NO