fix(dropSchema): missing mssql implementation #9081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerfowler The test is failing |
Drops all tables and constraints associated with a MSSQL schema Closes sequelize#9080
Added top 1/order by to the guarantee constraints are dropped first. Also added more tests to add/drop schemas with constraints.
Fixing issue with prior commit that broke platforms that don't natively support schemas
|
Sorry, @sushantdhiman, I'm not sure I follow what you're asking for. Am I not supposed to use arrow functions in test code? Can you give an example of the proper approach test code should follow? |
|
@jerfowler With arrow function we dont need to keep reference of parent scope So keep using arrow functions but get rid of |
…riable Using arrow functions we don't need to keep track of the parent `this` scope.
|
Not sure why that sqlite test failed... nothing I did. Can we force a retest and see if it clears? |
|
Closing the Pull request and Reopening worked, all tests pass! woohoo! |
sushantdhiman
approved these changes
Feb 28, 2018
eseliger
approved these changes
Feb 28, 2018
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
This implements dropSchema for MSSQL.
Closes #9080