fix(selectQuery): Don't add empty HAVING clause #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, added one. |
jorrit
force-pushed
the
emptyhaving
branch
2 times, most recently
from
e2047fd
to
f97fa72
Compare
| return { | ||
| subQuery: true, | ||
| tableAs: 'test', | ||
| having: { creationYear: { gt: 2002 } } |
There was a problem hiding this comment.
Will do. I didn't do this because none of the tests seem to use Op.
There was a problem hiding this comment.
In v5 all tests will move to operators, this is something we are doing with new tests
sushantdhiman
approved these changes
Jan 22, 2018
|
Thanks for merging! |
|
Thanks for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
When querying with empty
havingobject, the query contains an emptyHAVINGclause. The code processing thewhereobject checks if it contains any statements, the code processinghavingdidn't. I added that.