Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix scope typing #10803

Merged
merged 1 commit into from Apr 20, 2019

Conversation

Chocobozzz
Copy link
Contributor

When we use an array of string and methods

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving? No
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? no
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

We can mix scope names and method objects in the scope function

When we use an array of string and methods
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #10803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10803   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          94       94           
  Lines        9008     9008           
=======================================
  Hits         8678     8678           
  Misses        330      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d6795...150903a. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 032d996 into sequelize:master Apr 20, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants