fix(model): handle virtual attributes in includes #10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danconnell
commented
Apr 17, 2019
| @@ -699,7 +698,7 @@ class Model { | |||
|
|
|||
| // Validate child includes | |||
| if (include.hasOwnProperty('include')) { | |||
| this._validateIncludedElements.call(include.model, include, tableNames, options); | |||
There was a problem hiding this comment.
This is just cleanup
Codecov Report
@@ Coverage Diff @@
## master #10785 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 94 94
Lines 9006 9006
=======================================
Hits 8676 8676
Misses 330 330
Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Apr 17, 2019
|
🎉 This PR is included in version 5.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fix virtual attributes used in includes to be returned by
getafter the model is loaded #10552originalAttributeswasn't being set before callingUtils.mapFinderOptionslike it is in other places