Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): extend FindOptions with QueryOptions #10766

Merged
merged 1 commit into from Apr 15, 2019

Conversation

ppetzold
Copy link
Contributor

@ppetzold ppetzold commented Apr 14, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

FindOptions is missing most query options like useMaster etc.

According to @mickhansen #3977 (comment) all query options are being passed on, that's why we can directly extend FindOptions with QueryOptions.

@codecov
Copy link

codecov bot commented Apr 14, 2019

Codecov Report

Merging #10766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10766   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          93       93           
  Lines        8992     8992           
=======================================
  Hits         8662     8662           
  Misses        330      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6c60d...2fbe6e8. Read the comment docs.

Copy link
Contributor

@SimonSchick SimonSchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate a test but this is simple enough.

@sushantdhiman sushantdhiman merged commit 2f6e01b into sequelize:master Apr 15, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants