feat(typings): model.count with group by

[mirkojotic]

Pull Request check-list

Please make sure to review and check all of these items:

• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Have you added new tests to prevent regressions?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Solves #10757 hopefully :)

I'm not well versed in typescript but if there are changes to make I'm up for it. As always if it's not useful please ignore.

Description of change

[codecov]

Codecov Report

Merging #10763 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10763      +/-   ##
==========================================
- Coverage   96.33%   96.33%   -0.01%     
==========================================
  Files          93       93              
  Lines        8993     8992       -1     
==========================================
- Hits         8663     8662       -1     
  Misses        330      330

Impacted Files	Coverage Δ
lib/dialects/mssql/connection-manager.js	87.01% <0%> (-0.17%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e879460...28e5536. Read the comment docs.

[SimonSchick]

Needs test.

[mirkojotic]

No problem, can you point me to an example. Not sure how testing of type definitions is done.

…

On Sat, Apr 13, 2019, 08:49 Simon Schick ***@***.***> wrote: ***@***.**** requested changes on this pull request. Needs test. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10763 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKKKcPZf0BvO5-2K2-IVfFYXv57gaiDpks5vgdI-gaJpZM4cskEo> .

[SimonSchick]

Just create something like count.ts into the type test folder and write 2 lines (or more) that assert that the overloads return the correct values, please keep in mind that the code isn't executed, it just needs to compile.

[sushantdhiman]

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀