fix(mariadb): named timezone connection bug

[javiertury]

Mariadb doesn't support named timezones. Previous workaround missed connectionConfig.timezone. It didn't show on online tests, because they use UTC.

[codecov]

Codecov Report

Merging #10705 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10705      +/-   ##
==========================================
+ Coverage    96.3%   96.31%   +0.01%     
==========================================
  Files          93       93              
  Lines        8976     8976              
==========================================
+ Hits         8644     8645       +1     
+ Misses        332      331       -1

Impacted Files	Coverage Δ
lib/dialects/mariadb/connection-manager.js	100% <100%> (ø)	⬆️
lib/dialects/mariadb/data-types.js	100% <0%> (+1.96%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c9117...60e7968. Read the comment docs.

[sushantdhiman]

enable this test for mariadb

[sushantdhiman]

🎉 This PR is included in version 5.2.13 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[rusher]

hmm, that PR doesn't really solve the issue, but create more problems.
timezone is now initialized to some offset, but for timezone with daylight saving time (DST) for example, that will result in having new offset when changing to summer/winter time for example.

Last driver release now support IANA timezone.

Better to revert that change

[javiertury]

@rusher I think your points are valid. However this pull request didn't decide to convert named timezones to hour offsets. That was probably decided earlier in another commit. This pull request addresses how they are converted.

Previously the connection was initialized using raw options.timezone, and the timezone was immediately changed to an hour offset using SET time_zone = '${tzOffset}';. This pull request initializes the connection with an hour offset directly, so the connection doesn't crash. Before and after this commit, the final timezone has always been an hour offset. The difference is that the driver doesn't throw any errors.