Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add version property to init options #10681

Merged
merged 1 commit into from Apr 2, 2019

Conversation

SimonSchick
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #10641

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #10681 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10681      +/-   ##
==========================================
- Coverage    96.2%   96.19%   -0.02%     
==========================================
  Files          93       93              
  Lines        9011     9011              
==========================================
- Hits         8669     8668       -1     
- Misses        342      343       +1
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 93.84% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec86a4...aacb52c. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 0f505ef into master Apr 2, 2019
@sushantdhiman sushantdhiman deleted the fix/types-version branch April 2, 2019 04:56
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

ALiangLiang pushed a commit to ALiangLiang/sequelize that referenced this pull request Apr 3, 2019
@eddiemonge
Copy link

@SimonSchick This breaks Sequelize instances. I get:

Property 'models' does not exist on type 'Sequelize'. Did you mean 'model'?

After doing const db = new Sequelize({...}); db.models

Specifically the version?:... line. Removing that restores the type recognition for Models (but obviously removes the types for the version property.

@SimonSchick
Copy link
Contributor Author

@eddiemonge please create a new issue with a full repro etc., I am not getting any issues with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants