fix(query-generator): convert numbers to date types #10569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it doesn't like the timezone being included for some reason, it works fine locally.. |
sushantdhiman
approved these changes
Mar 18, 2019
|
@sushantdhiman I'll be pretty busy with work for a while, can you look into this? |
eseliger
reviewed
Mar 22, 2019
package.json
Outdated
| @@ -121,15 +121,15 @@ | |||
| "test-docker-integration": "env-cmd $npm_package_options_env_cmd npm run test-integration", | |||
| "docs": "esdoc && cp docs/ROUTER esdoc/ROUTER && cp docs/favicon.ico esdoc/favicon.ico", | |||
| "teaser": "node scripts/teaser", | |||
| "test-unit": "mocha --require scripts/mocha-bootload --globals setImmediate,clearImmediate --exit --check-leaks --colors -t 30000 --reporter spec \"test/unit/**/*.js\"", | |||
There was a problem hiding this comment.
is this related to the issue? or is it just not needed anymore?
There was a problem hiding this comment.
Oh, I didn't really mean to commit this but no, this isn't needed anymore.
There was a problem hiding this comment.
maybe we can put this in a separate pr then so if it would cause trouble at some end it's easier to pin it down using bisect
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fixes #10563
Also renamed some tests as using mocha's
-f GREBdoesn't work well with$.