Possible error in plugin loading logic, says Succeed and Fail for @semantic-release/github #811
Comments
|
Ah never mind... See |
|
@pvdlg seems like this has tripped people up a few times. i wonder if double-quoting the plugin names, or something similar, would be enough to clarify this for users. |
|
Yes. The quotes seems a good idea. Do you want to make a PR? |
|
sure, i could put something together tonight. |
travi
added a commit
to travi/semantic-release
that referenced
this issue
Jun 6, 2018
added quotes around plugin name to set it apart from the message. without the quotes, some consumers were missunderstanding the successful loading of the `fail` plugin as a load failure and assuming something was broken resolves semantic-release#811
gr2m
pushed a commit
that referenced
this issue
Jun 6, 2018
added quotes around plugin name to set it apart from the message. without the quotes, some consumers were missunderstanding the successful loading of the `fail` plugin as a load failure and assuming something was broken resolves #811
|
🎉 This issue has been resolved in version 15.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
See logs for Travis CI. It loads the plugin and then says "Succeed" and "Fail" which shouldn't both be possible.
Expected behavior
Should just print "Succeed" message.
Environment
npx semantic-releaseThe text was updated successfully, but these errors were encountered: