Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
16 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this commit breaks https://github.com/conveyal/maven-semantic-release and probably other plugins who use the git library.
Wouldn't it be better to add a new function "pushTags" instead?
2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it breaks it? Without any explanation there is nothing we can do.
2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being inaccurate.
In this case the the https://github.com/conveyal/maven-semantic-release is using the 'git push' function to update the pom.xml with absolut and next-snapshot version. this doesn't work after the change of pushing tags only anymore.
also the new push function is confusion now what exactly it is doing now. i would expect if i wanna reuse this function to push my commits which is now longer working now
hope this helps
2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"It's broken" or "it doesn't work" doesn't mean anything and doesn't allow to analyze anything. You have to explain clearly what is supposed to happen that doesn't happen or what error message you get.
I don't understand the connection there. What does your plugin pushing a commit and semantic-release core pushing tags have to do with each other?
That's two distinguished even that doesn't impact each other. Moreover the push of the tags happen after the
prepare
step of your plugin that push a commit.I don't understand either your comment about adding a
pushTags
function or the fact that the namepush
is confusing. That's internal code, it's never called by anything other than code in semantic-release core.2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing that out. I'll update the plugin accordingly!
Thanks for your great plugin
2b082ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, out of curiosity, what was the problem? Were you using those internal functions somehow?