fix: deduplicate glob results by resolved path

semantic-release · Aug 26, 2018 · 704ac79 · 704ac79
1 parent 2090a90
commit 704ac79
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/glob-assets.js b/lib/glob-assets.js
@@ -67,5 +67,5 @@ module.exports = async ({cwd}, assets) =>
       )
       .sort(asset => !isPlainObject(asset)),
     // Compare `path` property if Object definition, value itself if String
-    (a, b) => (isPlainObject(a) ? a.path : a) === (isPlainObject(b) ? b.path : b)
+    (a, b) => path.resolve(cwd, isPlainObject(a) ? a.path : a) === path.resolve(cwd, isPlainObject(b) ? b.path : b)
   );
diff --git a/test/glob-assets.test.js b/test/glob-assets.test.js
@@ -183,3 +183,11 @@ test('Include empty directory as defined', async t => {
 
   t.deepEqual(globbedAssets, ['empty']);
 });
+
+test('Deduplicate resulting files path', async t => {
+  const cwd = tempy.directory();
+  await copy(fixtures, cwd);
+  const globbedAssets = await globAssets({cwd}, ['./upload.txt', path.resolve(cwd, 'upload.txt'), 'upload.txt']);
+
+  t.deepEqual(globbedAssets, ['upload.txt']);
+});