Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on lodash.isarray #1829

Closed
daltones opened this issue Dec 10, 2016 · 2 comments
Closed

Dependency on lodash.isarray #1829

daltones opened this issue Dec 10, 2016 · 2 comments

Comments

@daltones
Copy link
Contributor

I saw that 79e86f3 introduced a dependency on lodash.isarray among others.

Is that really necessary? Any particular reason to not use the standard Array.isArray()?

Array.isArray() already appears in other parts of the code and we're having this message on install:

warning node-sass > lodash.isarray@4.0.0: This package is deprecated. Use Array.isArray.
@daltones daltones mentioned this issue Dec 10, 2016
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Dec 11, 2016

Array.isArray is not available until Node 4.6.2. We support back to Node 0.10.

@xzyfer xzyfer closed this as completed Dec 11, 2016
@xzyfer xzyfer reopened this Dec 11, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Dec 11, 2016

My apologies you are correct. Fixed by #1830.

@xzyfer xzyfer closed this as completed Dec 11, 2016
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
@mgreter
Merge pull request sass#1829 from mgreter/feature/import-recursion-check
ed6a057 
Implement import recursion check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xzyfer @daltones