Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly no longer needed #13

Closed
medikoo opened this issue Aug 23, 2021 · 2 comments
Closed

Possibly no longer needed #13

medikoo opened this issue Aug 23, 2021 · 2 comments

Comments

@medikoo
Copy link
Contributor

medikoo commented Aug 23, 2021

I think functionality of this plugin is already supported by Framework natively, as you can configure:

functions:
  someFunction:
    events:
      - http:
          ....
          response:
            contentHandling: CONVERT_TO_BINARY

It was added with serverless/serverless#6987 which was released with https://github.com/serverless/serverless/releases/tag/v1.59.0

If my understanding is correct it might be nice to deprecate it with appropriate messages
@ryanmurakami
Copy link
Owner

Hi @medikoo,
Yes, you are totally right. Glad to see it's built into the framework now. I'll add a message in the future. Thanks!

@ryanmurakami
Copy link
Owner

Just merged your PR to handle the deprecation message. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@medikoo @ryanmurakami