Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail how return values from augmentChunkHash are used #3432

Merged
merged 1 commit into from Mar 10, 2020

Conversation

jakearchibald
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

From reading the docs, it wasn't clear to me how the value returned from augmentChunkHash would be used. I added a link to hash.update so plugin authors could refer to the node docs for valid types. I also modified the example so it was returning a valid type.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #3432 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3432   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         171      171           
  Lines        5831     5831           
  Branches     1722     1722           
=======================================
  Hits         5540     5540           
  Misses        157      157           
  Partials      134      134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43bb7e...c1eec2e. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 9d4a49f into rollup:master Mar 10, 2020
sthagen added a commit to sthagen/rollup-rollup that referenced this pull request Mar 10, 2020
Detail how return values from `augmentChunkHash` are used (rollup#3432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants