Code splitting : Identifier 'React' has already been declared

[camille-hdl]

Hello

• Rollup Version: 1.2.2
• Operating System (or Browser): Chrome 72 on MacOS 10.14.11
• Node Version: 11.6.0

How Do We Reproduce?

https://github.com/camille-hdl/rollup-starter-code-splitting

(instructions in the readme)

• Dynamically import a component (that imports React) from another file that also imports React,
• Build the application, run it in the browser.

Expected Behavior

React is not aliased twice, the page works.

Actual Behavior

In the output, React is aliased twice in a import statement:

import { ..., d as React, e as require$$1, f as require$$2, g as React } from './chunk....js';

resulting in the following error message in the console:

Uncaught (in promise) SyntaxError: Identifier 'React' has already been declared

[camille-hdl]

update : it seems the issue is not present in older versions of rollup (it worked with 1.0.1)

[lukastaegert]

Thanks for spotting this issue. Finally managed to reduce it to a minimal example:

https://rollupjs.org/repl?version=1.2.3&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QmZvbyU3RCUyMGZyb20lMjAnLiUyRmZvbyclM0IlNUNuaW1wb3J0JTIwYmFyJTIwZnJvbSUyMCcuJTJGcHJveHknJTNCJTVDbiU1Q25jb25zb2xlLmxvZyhmb28lMkMlMjBiYXIpJTNCJTIyJTJDJTIyaXNFbnRyeSUyMiUzQXRydWUlN0QlMkMlN0IlMjJuYW1lJTIyJTNBJTIyZm9vLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmV4cG9ydCUyMGNvbnN0JTIwZm9vJTIwJTNEJTIwJTdCJTdEJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTdEJTJDJTdCJTIybmFtZSUyMiUzQSUyMnByb3h5LmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QmZvbyU3RCUyMGZyb20lMjAnLiUyRmZvbyclM0IlNUNuZXhwb3J0JTIwZGVmYXVsdCUyMGZvbyUzQiUyMiU3RCUyQyU3QiUyMm5hbWUlMjIlM0ElMjJjb21iaW5lZC5qcyUyMiUyQyUyMmNvZGUlMjIlM0ElMjJpbXBvcnQlMjAnLiUyRmZvbyclM0IlNUNuaW1wb3J0JTIwJy4lMkZwcm94eSclMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSU3RCU1RCUyQyUyMm9wdGlvbnMlMjIlM0ElN0IlMjJmb3JtYXQlMjIlM0ElMjJlc20lMjIlMkMlMjJuYW1lJTIyJTNBJTIybXlCdW5kbGUlMjIlMkMlMjJhbWQlMjIlM0ElN0IlMjJpZCUyMiUzQSUyMiUyMiU3RCUyQyUyMmdsb2JhbHMlMjIlM0ElN0IlN0QlN0QlMkMlMjJleGFtcGxlJTIyJTNBbnVsbCU3RA==

Hope to fix it soon.

[lukastaegert]

Fix at #2719

[camille-hdl]

that was fast ! thank you 👍