Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup 1.11 changed AMD output #2837

Closed
surma opened this issue May 5, 2019 · 4 comments
Closed

Rollup 1.11 changed AMD output #2837

surma opened this issue May 5, 2019 · 4 comments

Comments

@surma
Copy link

surma commented May 5, 2019

How Do We Reproduce?

Expected Behavior

require() calls should use .js extension.

Actual Behavior

They don’t.

This might be related to #2831

@lukastaegert
Copy link
Member

Is this actually causing issues for you? This was changed intentionally as requirejs will only use the proper relative resolution algorithm respecting base urls etc. if the extension is skipped. I.e. to my knowledge to make AMD work correctly, extensions need to be skipped.

@surma
Copy link
Author

surma commented May 5, 2019

Hm, I was relying on the file extension being present for the AMD loader I wrote for loadz0r. I just thought this would be considered a breaking change.

Either way, happy to adjust loadz0r just wanted to make sure it was an intentional change.

@lukastaegert
Copy link
Member

Yes, sorry about that! I was thinking long if it would be a breaking change but on the other, the old behaviour was just not working when not all chunks were in the same directory so I thought it was too important to keep it for the next major.

@surma
Copy link
Author

surma commented May 5, 2019

Alright, that seems reasonable. I’ll fix loadz0r :)

@surma surma closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants