Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot split a chunk that has already been edited #2676

Closed
Rich-Harris opened this issue Feb 3, 2019 · 2 comments
Closed

Cannot split a chunk that has already been edited #2676

Rich-Harris opened this issue Feb 3, 2019 · 2 comments
Labels
t¹ 🐞 bug

Comments

@Rich-Harris
Copy link
Contributor

  • Rollup Version: 1.1.2
  • Operating System (or Browser): MacOS
  • Node Version: 11.6.0

How Do We Reproduce?

Expected Behavior

It bundles

Actual Behavior

It doesn't bundle. Instead, we get the same error as in #2660 —

[!] Error: Cannot split a chunk that has already been edited (0:7 – "import('./b.js')")
@Rich-Harris
Copy link
Contributor Author

Rich-Harris commented Feb 3, 2019 •
edited

Very slightly simpler repro

Rich-Harris added a commit that referenced this issue Feb 3, 2019
@Rich-Harris
failing test for #2676
364e3fe
@Rich-Harris Rich-Harris mentioned this issue Feb 3, 2019
Merged
9 tasks
lukastaegert pushed a commit that referenced this issue Feb 14, 2019
@Rich-Harris @lukastaegert
failing test for #2676
dbd0029
lukastaegert pushed a commit that referenced this issue Feb 15, 2019
@Rich-Harris @lukastaegert
failing test for #2676
a41738f
lukastaegert added a commit that referenced this issue Feb 15, 2019
@lukastaegert
Merge branch 'master' into gh-2676
0e30a97
lukastaegert pushed a commit that referenced this issue Feb 16, 2019
@Rich-Harris @lukastaegert
failing test for #2676
37f286b
lukastaegert pushed a commit that referenced this issue Feb 17, 2019
@Rich-Harris @lukastaegert
failing test for #2676
a9cb6d2
lukastaegert pushed a commit that referenced this issue Feb 17, 2019
@Rich-Harris @lukastaegert
Prevent final resolution and facade creation for inlined dynamic impo…
db42a04 
…rts (#2677)

* failing test for #2676

* skip final resolution if dynamic import has already been rendered

* add expected test output

* only mark dynamic import as replaced if it was completely overwritten

* * only render final resolutions for cross-chunk dynamic imports
* do not create facades for inlined dynamic imports

* Get rid of AppVeyor Node 8 test to speed up CI
@lukastaegert
Copy link
Member

Resolved via #2677

@haseebanwar haseebanwar mentioned this issue Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @lukastaegert