throw always considered to be a side effect

src/ast/nodes/ThrowStatement.js

@@ -1,7 +1,7 @@
 import Node from '../Node.js';
 
 export default class ThrowStatement extends Node {
-	hasEffects ( scope ) {
-		return scope.findLexicalBoundary().isModuleScope; // TODO should this just be `true`? probably...
+	hasEffects () {
+		return true;
 	}
 }

test/form/side-effect-h/_config.js

@@ -1,5 +1,5 @@
 module.exports = {
-	description: 'excludes non-top-level throw statements',
+	description: 'includes throw statements',
 	options: {
 		moduleName: 'myBundle'
 	}

test/form/side-effect-h/_expected/amd.js

@@ -1,5 +1,13 @@
 define(function () { 'use strict';
 
+	function foo ( ok ) {
+		if ( !ok ) {
+			throw new Error( 'this will be ignored' );
+		}
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;

test/form/side-effect-h/_expected/cjs.js

@@ -1,5 +1,13 @@
 'use strict';
 
+function foo ( ok ) {
+	if ( !ok ) {
+		throw new Error( 'this will be ignored' );
+	}
+}
+
+foo();
+
 var main = 42;
 
 module.exports = main;

test/form/side-effect-h/_expected/es.js

@@ -1,3 +1,11 @@
+function foo ( ok ) {
+	if ( !ok ) {
+		throw new Error( 'this will be ignored' );
+	}
+}
+
+foo();
+
 var main = 42;
 
 export default main;

test/form/side-effect-h/_expected/iife.js

@@ -1,6 +1,14 @@
 var myBundle = (function () {
 	'use strict';
 
+	function foo ( ok ) {
+		if ( !ok ) {
+			throw new Error( 'this will be ignored' );
+		}
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;

test/form/side-effect-h/_expected/umd.js

@@ -4,8 +4,16 @@
 	(global.myBundle = factory());
 }(this, (function () { 'use strict';
 
+	function foo ( ok ) {
+		if ( !ok ) {
+			throw new Error( 'this will be ignored' );
+		}
+	}
+
+	foo();
+
 	var main = 42;
 
 	return main;
 
-})));
+})));

test/form/side-effect-t/_config.js

@@ -0,0 +1,6 @@
+module.exports = {
+	description: 'throw statement is a side effect',
+	options: {
+		moduleName: 'myBundle'
+	}
+};

test/form/side-effect-t/_expected/amd.js

@@ -0,0 +1,9 @@
+define(function () { 'use strict';
+
+	function foo () {
+		throw new Error( 'throw side effect' );
+	}
+
+	foo();
+
+});

test/form/side-effect-t/_expected/cjs.js

@@ -0,0 +1,7 @@
+'use strict';
+
+function foo () {
+	throw new Error( 'throw side effect' );
+}
+
+foo();

test/form/side-effect-t/_expected/es.js

@@ -0,0 +1,5 @@
+function foo () {
+	throw new Error( 'throw side effect' );
+}
+
+foo();

test/form/side-effect-t/_expected/iife.js

@@ -0,0 +1,10 @@
+(function () {
+	'use strict';
+
+	function foo () {
+		throw new Error( 'throw side effect' );
+	}
+
+	foo();
+
+}());

test/form/side-effect-t/_expected/umd.js

@@ -0,0 +1,13 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(factory());
+}(this, (function () { 'use strict';
+
+	function foo () {
+		throw new Error( 'throw side effect' );
+	}
+
+	foo();
+
+})));

test/form/side-effect-t/main.js

@@ -0,0 +1,5 @@
+function foo () {
+	throw new Error( 'throw side effect' );
+}
+
+foo();