From b5081ba9c73a61a32ee36d966387287296ce01f7 Mon Sep 17 00:00:00 2001 From: Lukas Taegert Date: Fri, 10 Nov 2017 07:47:08 +0100 Subject: [PATCH] * Forgot to forward the arguments for .render(code, es) * Resolve #1708 --- src/ast/nodes/SequenceExpression.js | 2 +- test/form/samples/sequence-expression/_expected/amd.js | 3 +++ test/form/samples/sequence-expression/_expected/cjs.js | 3 +++ test/form/samples/sequence-expression/_expected/es.js | 3 +++ test/form/samples/sequence-expression/_expected/iife.js | 3 +++ test/form/samples/sequence-expression/_expected/umd.js | 3 +++ test/form/samples/sequence-expression/main.js | 3 +++ 7 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/ast/nodes/SequenceExpression.js b/src/ast/nodes/SequenceExpression.js index 7f750a0fb4a..80077a4128c 100644 --- a/src/ast/nodes/SequenceExpression.js +++ b/src/ast/nodes/SequenceExpression.js @@ -41,7 +41,7 @@ export default class SequenceExpression extends Node { } else { let previousEnd = this.start; for ( const expression of included ) { - expression.render(); + expression.render( code, es ); code.remove( previousEnd, expression.start ); code.appendLeft( expression.end, ', ' ); previousEnd = expression.end; diff --git a/test/form/samples/sequence-expression/_expected/amd.js b/test/form/samples/sequence-expression/_expected/amd.js index 59bc8bc0f3f..902ad8005b0 100644 --- a/test/form/samples/sequence-expression/_expected/amd.js +++ b/test/form/samples/sequence-expression/_expected/amd.js @@ -17,4 +17,7 @@ define(function () { 'use strict'; // should keep f import var e = (foo$1()); + // should properly render complex sub-expressions + var g = ((() => {console.log(foo$1());})(), 1); + }); diff --git a/test/form/samples/sequence-expression/_expected/cjs.js b/test/form/samples/sequence-expression/_expected/cjs.js index 6cf415b0706..01c5cdcbf11 100644 --- a/test/form/samples/sequence-expression/_expected/cjs.js +++ b/test/form/samples/sequence-expression/_expected/cjs.js @@ -16,3 +16,6 @@ console.log(d); // should infer value // should keep f import var e = (foo$1()); + +// should properly render complex sub-expressions +var g = ((() => {console.log(foo$1());})(), 1); diff --git a/test/form/samples/sequence-expression/_expected/es.js b/test/form/samples/sequence-expression/_expected/es.js index be18ce81e4d..694de8abb64 100644 --- a/test/form/samples/sequence-expression/_expected/es.js +++ b/test/form/samples/sequence-expression/_expected/es.js @@ -14,3 +14,6 @@ console.log(d); // should infer value // should keep f import var e = (foo$1()); + +// should properly render complex sub-expressions +var g = ((() => {console.log(foo$1());})(), 1); diff --git a/test/form/samples/sequence-expression/_expected/iife.js b/test/form/samples/sequence-expression/_expected/iife.js index c51928e9733..ad367be83c2 100644 --- a/test/form/samples/sequence-expression/_expected/iife.js +++ b/test/form/samples/sequence-expression/_expected/iife.js @@ -18,4 +18,7 @@ // should keep f import var e = (foo$1()); + // should properly render complex sub-expressions + var g = ((() => {console.log(foo$1());})(), 1); + }()); diff --git a/test/form/samples/sequence-expression/_expected/umd.js b/test/form/samples/sequence-expression/_expected/umd.js index 712539febe2..e75a869f169 100644 --- a/test/form/samples/sequence-expression/_expected/umd.js +++ b/test/form/samples/sequence-expression/_expected/umd.js @@ -21,4 +21,7 @@ // should keep f import var e = (foo$1()); + // should properly render complex sub-expressions + var g = ((() => {console.log(foo$1());})(), 1); + }))); diff --git a/test/form/samples/sequence-expression/main.js b/test/form/samples/sequence-expression/main.js index 3a5d2086ea6..c50e6cef4a2 100644 --- a/test/form/samples/sequence-expression/main.js +++ b/test/form/samples/sequence-expression/main.js @@ -18,3 +18,6 @@ if ((1, 2) !== 2) { // should keep f import var e = (0, f.foo()); + +// should properly render complex sub-expressions +var g = ((() => {})(), (() => {console.log(f.foo())})(), 1);