Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect column numbers #74

Closed
qrohlf opened this issue Nov 30, 2015 · 4 comments
Closed

Incorrect column numbers #74

qrohlf opened this issue Nov 30, 2015 · 4 comments

Comments

@qrohlf
Copy link

qrohlf commented Nov 30, 2015

I'm getting some nonsensical underlining when using linter-js-standard in my project:

screen shot 2015-11-30 at 11 49 12 am

That's with the default settings on a fresh install of Atom.

For reference, here's how that same file looks in Sublime using sublime-linter and Sublime​Linter-contrib-standard

screen shot 2015-11-30 at 11 49 19 am

Note how the quote is highlighted and so is the non-existent variable.

@qrohlf
Copy link
Author

qrohlf commented Nov 30, 2015

For reference, here is the complete text of my test case:

var foo = "bar"
console.log(foo)

foo = doesNotExist

@ricardofbarros
Copy link
Owner

Hey @qrohlf, thanks for your report and sorry for the late reply.

This is a known issue on eslint ecosystem. Basically it's missing a range property on the report so we could know where the violation starts and ends.

But there's something going on there. It should have had highlighted the code until a EOL, but it's doing the opposite, I'll take a look into it.

@gabmontes
Copy link

Same issue here:

screen shot 2016-03-02 at 17 54 34

Running Atom 1.5.3 on Mac OS X 10.11.3
linter@1.11.3
linter-js-standard@3.2.1

Any news on this?

@sonicdoe
Copy link
Collaborator

Range highlighting is now considerably improved in 24e76ae and e5d31dc.

For example, @qrohlf’s code snippet now looks like this:

Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants