Fix nodemon installation for node 10.x and beyond #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2018 11:39
The commit 97f8d0a introduces versions prefixed with carets whereas this lockfile needs to pin each dependencies (same when a user executes `npm i`).
this version (paulmillr/chokidar@11aea72) fixes the issue related to "upath" that was limiting the node runtime to 9.x (https://github.com/anodynos/upath/blob/v1.0.2/package.json#L43).
|
it's weird that travis tests has failed as i launch mine locally using |
|
Wow, that was quick! 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today i was preparing our projects for the LTS release of Node.js 10 but was stopped as your package is using a version of chokidar that was using a dependency (upath) which prevents any version beyond 9 (https://github.com/anodynos/upath/blob/v1.0.2/package.json#L43) so i've just bumped chokidar to the first version that has fixed this (paulmillr/chokidar@11aea72).
This issue will happen to anybody that is using a lockfile (specifically
yarn.lock) that references any version ofnodemonup to the current release and switch to node 10 (which could happen more and more often after the LTS release 馃槈).