Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong incrementation on prepatch #588

Closed
Sharcoux opened this issue Jan 14, 2020 · 10 comments
Closed

Wrong incrementation on prepatch #588

Sharcoux opened this issue Jan 14, 2020 · 10 comments
Labels

Comments

@Sharcoux
Copy link

Sharcoux commented Jan 14, 2020

Maybe I'm misunderstanding how prepatch is supposed to work, but I was at 0.10.4, I then did a prepatch and went to 0.10.5-0. I want to release the next prepatch this is considered to be 0.10.6-0. Shouldn't it be 0.10.5-1?

Thanks for your very helpful package!

@webpro
Copy link
Collaborator

webpro commented Jan 14, 2020

  • A prepatch when on 0.10.5 results in 0.10.6-0.
  • When on 0.10.5-0 there was also a higher version 0.10.5, so the prepatch after this became 0.10.6-0.

@Sharcoux
Copy link
Author

Sharcoux commented Jan 14, 2020

My bad. I was on 0.10.4. I messed up in my question. The issue remain. After 0.10.5-0 should be 0.10.5-1, no?

@webpro
Copy link
Collaborator

webpro commented Jan 15, 2020

After 0.10.5-0 should be 0.10.5-1, no?

Yes. What command(s) did you use? I guess a release-it prepatch and/or the --preRelease argument?

@Sharcoux
Copy link
Author

Sharcoux commented Jan 16, 2020

I was using the prompt that let you choose between patch, minor, major, prepatch, preRelease, and other when using just release-it.
I will try on a new version to see if it happens again.
I forgot to check the current installed version in my project. Let me do that first!

@Sharcoux
Copy link
Author

Ok, I'm with v 12.4.3.

@webpro
Copy link
Collaborator

webpro commented Jan 16, 2020

I'm going to close this issue for now. Feel free to re-open when you encounter any issues. By the way, release-it uses the semver package.

@webpro webpro closed this as completed Jan 16, 2020
@Sharcoux
Copy link
Author

I can confirm the bug. I was on 11.0,
prepatch -> 11.0.1-0,
next prepatch is 11.0.2-0

v12.4.3

@Sharcoux
Copy link
Author

@webpro I cannot re-open. I don't have enough privilege...

@webpro
Copy link
Collaborator

webpro commented Feb 7, 2020

I can indeed reproduce this using the version selector in interactive mode.

I always use release --preRelease for continuation pre-releases (which works well).

But I'll leave this open as this is definitely a bug I'll fix soon.

@webpro
Copy link
Collaborator

webpro commented Feb 18, 2020

Should be fixed in v12.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants