Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations for version updates #1064

Open
97vack opened this issue Nov 15, 2023 · 4 comments
Open

Recommendations for version updates #1064

97vack opened this issue Nov 15, 2023 · 4 comments

Comments

@97vack
Copy link

97vack commented Nov 15, 2023

I update the version and generate logs every time I commit. What I hope to do is trigger this release workflow only when the commit prefix is feature or fix, such as updating the version and generating logs. However, now when I submit a commit of type docs or style, this workflow will also be triggered. What should I do?

This is my release it

image

@tginiotis-at-work
Copy link

I have patched release-it's code on my build environment to exclude commits with certain messages/prefixes with:

sed -i 's@git rev-list@git rev-list --grep="^PREFIX_I_DO_NOT_WANT" --invert-grep@g' /usr/local/lib/node_modules/release-it/lib/plugin/git/Git.js

Would be nice to have it as a configurable feature though.

@97vack
Copy link
Author

97vack commented Nov 15, 2023

I have patched release-it's code on my build environment to exclude commits with certain messages/prefixes with:

sed -i 's@git rev-list@git rev-list --grep="^PREFIX_I_DO_NOT_WANT" --invert-grep@g' /usr/local/lib/node_modules/release-it/lib/plugin/git/Git.js

Would be nice to have it as a configurable feature though.

Thank you for your feedback, but how should I use your plugin and the code above?

@tginiotis-at-work
Copy link

It is not a plugin, but a "dirty" hack. I wrote the sed command that patches the Git.js file. ^PREFIX_I_DO_NOT_WANT is the regex that excludes messages that start with PREFIX_I_DO_NOT_WANT. You will have to figure out how to apply it to your case.

@97vack
Copy link
Author

97vack commented Nov 15, 2023

It is not a plugin, but a "dirty" hack. I wrote the sed command that patches the Git.js file. ^PREFIX_I_DO_NOT_WANT is the regex that excludes messages that start with PREFIX_I_DO_NOT_WANT. You will have to figure out how to apply it to your case.

Thank you for your help. I think I understand what you mean. I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants