You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest version of whatwg-url does not print this warning anymore. However, this requires upgrading @octokit/rest from v19 to v20. Doing so would drop support for Node 16 (which is not officially supported anymore by Node.js).
This would also remove the agent feature, which is currently used by the github.proxy option.
The original PR that removed that feature is octokit/request.js#599. Instead, a custom fetch should be passed instead. If support for Node <18.13.0 is removed, the global fetch() method can be used without printing an experimental warning. Under the hood, it uses undici.fetch(). An Agent can be passed, but I am unclear whether it must be an undiciAgent (which would require adding undici as a dependency) or a core Node.js httpAgent.
The text was updated successfully, but these errors were encountered:
ehmicky
changed the title
Fix punycode deprecation warning
Fix punycode deprecation warning since Node 21
Oct 27, 2023
The following warning is currently printed when using Node 21:
This is coming from https://github.com/jsdom/whatwg-url/blob/d34854a7af6ed1204f55d7da7761497bad350a7b/src/url-state-machine.js#L2 which is installed through:
The latest version of
whatwg-url
does not print this warning anymore. However, this requires upgrading@octokit/rest
from v19 to v20. Doing so would drop support for Node 16 (which is not officially supported anymore by Node.js).This would also remove the
agent
feature, which is currently used by thegithub.proxy
option.release-it/lib/plugin/github/GitHub.js
Lines 181 to 183 in 9e99e2b
The original PR that removed that feature is octokit/request.js#599. Instead, a custom
fetch
should be passed instead. If support for Node<18.13.0
is removed, the globalfetch()
method can be used without printing an experimental warning. Under the hood, it usesundici.fetch()
. AnAgent
can be passed, but I am unclear whether it must be anundici
Agent
(which would require addingundici
as a dependency) or a core Node.jshttp
Agent
.The text was updated successfully, but these errors were encountered: