Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerise release-it for executing without node runtime #1045

Closed
juancarlosjr97 opened this issue Oct 5, 2023 · 8 comments
Closed

Dockerise release-it for executing without node runtime #1045

juancarlosjr97 opened this issue Oct 5, 2023 · 8 comments

Comments

@juancarlosjr97
Copy link
Contributor

Hello,

I was wondering if you have considered Dockerise the project to run the release and publish a docker version of it that just executes and that is it.

If not, and the idea sounds good, I am happy to contribute and raise the first MRs with some thoughts around it.

@juancarlosjr97 juancarlosjr97 changed the title Dockerise the project Dockerise release-it for executing without the need of node Oct 5, 2023
@juancarlosjr97 juancarlosjr97 changed the title Dockerise release-it for executing without the need of node Dockerise release-it for executing without node runtime Oct 5, 2023
@webpro
Copy link
Collaborator

webpro commented Oct 5, 2023

I haven't considered that before, because I'm not a Docker expert. But I'm willing to include it, since it should be low maintenance (someone added a Dockerfile in another project which went well).

@juancarlosjr97
Copy link
Contributor Author

Cool! I have an idea to manage additional dependencies besides the required one, and then we can go from there, I will try to get some time on it relatively soon :)

@juancarlosjr97
Copy link
Contributor Author

I am putting my thoughts as I finally got some time to work on it.

  • Dockerise works well
  • The user can pass the list of additional dependencies
  • The user can pass a list of additional commands to be executed

The problem... Git!

  • Git configuration can be copied into the image from the host to avoid enforced configuration by the image, but those enforcing SSH then require SSH to be installed which is not a problem, but then additional configuration such as SSH keys and SSH-agent running passed to the image is required.

Still working out the git part, but the rest was quite straightforward.

@juancarlosjr97
Copy link
Contributor Author

juancarlosjr97 commented Feb 10, 2024

Hey @webpro I finished the dockerised version. Tested internally in my projects, I made some decisions for GPG, SSH and GIT. I tested into multiple conditions and more to come, but so far all working :)

@webpro
Copy link
Collaborator

webpro commented Feb 10, 2024

Very cool! Sorry I didn't respond before. Thanks a lot for the updates, here's looking forward to the final version :)

@juancarlosjr97
Copy link
Contributor Author

All good! Fun weekend ahead for me :)

@juancarlosjr97
Copy link
Contributor Author

So.. I finished https://github.com/juancarlosjr97/release-it-containerized. My main drive for this was for project that do not run with node and do not need to have any configuration around it, and I would dare to say that I have done it! All done thanks to the amazing work of release-it that inspired me :)

@webpro
Copy link
Collaborator

webpro commented May 8, 2024

Guess we can close this one now, it's linked to from the docs here: https://github.com/release-it/release-it#containerized

Thanks for all the help and release-it-containerized!

@webpro webpro closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants