Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumper interprets characters in a git hash as a version string #36

Open
kwc2k opened this issue Apr 16, 2024 · 0 comments
Open

Bumper interprets characters in a git hash as a version string #36

kwc2k opened this issue Apr 16, 2024 · 0 comments

Comments

@kwc2k
Copy link

kwc2k commented Apr 16, 2024

When bumping a CMakeLists.txt file (as plain text), Bumper mistakenly interprets a subset of characters in a git hash as a string to be replaced with the new version. The CMakeLists.txt file contains the following code:

CPMAddPackage(
  NAME Foo
  GIT_TAG 205c73ac8d03c979e53206498b44ae123a150b0d
  GIT_REPOSITORY https://github.com/Foo
)

and the bumped file contains

CPMAddPackage(
  NAME Foo
  GIT_TAG 205c73ac8d03c979e53206498b44ae1.3.250b0d
  GIT_REPOSITORY https://github.com/Foo
)

The previous version was 1.3.1 which must be replaced with 1.3.2, hence the replacement in the GIT_TAG field is 123a1 to 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant