Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Prettier #1071

Merged
merged 3 commits into from Nov 6, 2018
Merged

Use Prettier #1071

merged 3 commits into from Nov 6, 2018

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented Nov 4, 2018

I saw @timdorr's suggestion to use Prettier in #1065 (comment) and decided to take a stab at integrating it. Given this project is already using ESLint, I thought running Prettier via ESLint was the simplest option (it does however mean that only linted files are run through Prettier, i.e. src, test/utils and test/components), but I'm happy to change the approach.

@netlify
Copy link

netlify bot commented Nov 4, 2018

Deploy preview for react-redux-docs ready!

Built with commit 1849851

https://deploy-preview-1071--react-redux-docs.netlify.com

package-lock.json Outdated Show resolved Hide resolved
@timdorr
Copy link
Member

timdorr commented Nov 6, 2018

OK, resolved the conflicts and updated the code. Thanks!

@timdorr timdorr merged commit 0c048f0 into reduxjs:master Nov 6, 2018
webguru7 pushed a commit to webguru7/react-redux that referenced this pull request Dec 8, 2022
* Use Prettier

* Make sure linting and formatting are part of the testing process.

* Run prettier on existing code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants