Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot build for iOS 8 device? #19

Closed
jihopark opened this issue Jan 18, 2016 · 6 comments
Closed

cannot build for iOS 8 device? #19

jihopark opened this issue Jan 18, 2016 · 6 comments
Labels

Comments

@jihopark
Copy link
Contributor

The iOS Deployment Target on RNDeviceInfo.xcodeproj has been set to iOS 9.0, so I couldn't build it since my app targets 8.0. So I had to change it to 8.0 on the library project file. I tested it on the 8.1 device on the simulator and had no problems.

I am wondering if there is a potential problem lowering this?

@jaggs6
Copy link
Contributor

jaggs6 commented Feb 3, 2016

+1 @rebeccahughes would it be possible to make this change?

@ghost
Copy link

ghost commented Feb 4, 2016

This is fixed and is on npm now

@ghost ghost closed this as completed Feb 4, 2016
@nicholasc
Copy link
Contributor

nicholasc commented Feb 23, 2018

I would like to re-open this.
I installed 0.16.0 a minute ago and the xcodeproj & podspec are still targeting iOS 9.0.

I am willing to submit a PR for this if approved by maintainers.

@machour machour reopened this Feb 23, 2018
@machour
Copy link
Collaborator

machour commented Feb 23, 2018

Will happily approve a PR for this, provided in doesn't brake anything compatibility wise :)

@nicholasc
Copy link
Contributor

Great, I'm on it.

@machour
Copy link
Collaborator

machour commented Feb 27, 2018

This was fixed in 0.17.2, thank you again @nicholasc !

@machour machour closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants