Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add null check for node in onDocumentDrop #517

Merged
merged 1 commit into from Oct 19, 2017

Conversation

pcgilday
Copy link
Contributor

What kind of change does this PR introduce?

  • bugfix

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

  • Protect calling this.node.contains when this.node is null
  • Fix IE11 bug where onDocumentDrop gets called with null this.node ref

closes #492

Protect against calling contains on null node ref

closes react-dropzone#492
@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files           3        3           
  Lines         197      197           
  Branches       51       51           
=======================================
  Hits          191      191           
  Misses          6        6
Impacted Files Coverage Δ
src/index.js 97.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd768b...4649ee9. Read the comment docs.

@okonet okonet merged commit 24c6ce5 into react-dropzone:master Oct 19, 2017
@okonet
Copy link
Collaborator

okonet commented Oct 19, 2017

Thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onDocumentDrop causes an error in IE
2 participants