Version 4.x stopped inferring options from ESLint config

[mrm007]

• prettier-eslint-cli version: 4.0.1
• prettier version: 1.3.1
• eslint version: 3.19.0

Relevant code/config.
See example repo. Run with yarn start. There is a v3 branch for prettier-eslint-config@3.

What you did:

With prettier-eslint-config@4 the inferred options are:

  "prettierOptions": {
    "bracketSpacing": true,
    "parser": "babylon",
    "printWidth": 80,
    "semi": true,
    "singleQuote": false,
    "tabWidth": 2,
    "trailingComma": "none",
    "useTabs": false,
  },

The expected options are the ones obtained with prettier-eslint-config@3:

  "prettierOptions": {
    "bracketSpacing": true,
    "parser": "babylon",
    "printWidth": 120,
    "semi": true,
    "singleQuote": true,
    "tabWidth": 2,
    "trailingComma": "all",
    "useTabs": false,
  },

Problem description:

The new behaviour is caused by the changes in #59, specifically this change. Default options specified for yargs take precedence so the ESLint config getters never get called:

[kentcdodds]

Ah! Yeah, that's a problem! Glad that I pushed that as a major version bump so it didn't mess everyone up unsuspectingly!

So I think that the problem is that the default values from the CLI should be used as fallbackPrettierOptions and right now they're being used as prettierOptions which overrides the prettier options.

So I'm pretty sure the solution would be to remove the default values for all the prettier options. prettier-eslint has the defaults already so there's really no need to have them at all.

Would you like to make a pull request to do that?

[mrm007]

Will do! I wasn't sure how to handle it but now that you gave me the answer, I can.