Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new frame with the same name as an existing frame to Texture results in incorrect frame count #4459

Closed
BigZaphod opened this issue Apr 5, 2019 · 1 comment

Comments

@BigZaphod
Copy link
Contributor

BigZaphod commented Apr 5, 2019

Phaser: 3.16.2

Texture's add() function to add a new frame increments the texture's frameTotal variable even if the given name already exists in the texture. It doesn't check to make sure the name is actually unique first. The code probably should just check for this case before deciding to increment the counter.

@photonstorm
Copy link
Collaborator

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants