New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'length' of undefined at windowCleaner #1625

Open

DanielHara opened this issue Oct 28, 2019 · 1 comment

DanielHara commented Oct 28, 2019 •

edited

What version of bluebird is the issue happening on?
3.7.1
What platform and version? (For example Node.js 0.12 or Google Chrome 32)
Node 12.9.1, jsdom@11.12.0
Did this issue happen with earlier version of bluebird?
Happens on upgrading from 3.7.0 to 3.7.1.
3.7.0 works fine

Upgrading from 3.7.0 to 3.7.1 broke my tests:

TypeError: Cannot read property 'length' of undefined
      at windowCleaner (../../node_modules/jsdom/lib/jsdom/browser/Window.js:487:41)
      at windowCleaner (../../node_modules/jsdom/lib/jsdom/browser/Window.js:488:9)
      at Window.close (../../node_modules/jsdom/lib/jsdom/browser/Window.js:495:6)

The text was updated successfully, but these errors were encountered:

Author

DanielHara commented Jan 13, 2020

I guess this has to do with this jsdom issue: jsdom/jsdom#1636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment