You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, GitHub makes it possible to get PGP keys of individual users through appending .gpg to the profile URL. For example, my key could be gotten from:
https://github.com/mgorny.gpg
However, the resulting ASCII-armored file does not contain a trailing newline. While this isn't a problem with GnuPG, it's rather non-standard to use "bare" files like this and it causes issues when multiple keys from GitHub are concatenated. Normally, concatenating ASCII-armored files is supposed to work but when files are taken from GitHub, the lack of trailing newline combines them into something like:
-----BEGIN PGP PUBLIC KEY BLOCK-----
...
-----END PGP PUBLIC KEY BLOCK----------BEGIN PGP PUBLIC KEY BLOCK-----
...
-----END PGP PUBLIC KEY BLOCK-----
which is not valid, and causes GnuPG to silently ignore the second key.
Would it be possible to add a newline to the generated output to improve interoperability?
[EDIT: actually, I think it's in violation of RFC 4880:
Note that all these Armor Header Lines are to consist of a complete
line. That is to say, there is always a line ending preceding the
starting five dashes, and following the ending five dashes.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Select Topic Area
Product Feedback
Body
Currently, GitHub makes it possible to get PGP keys of individual users through appending
.gpg
to the profile URL. For example, my key could be gotten from:However, the resulting ASCII-armored file does not contain a trailing newline. While this isn't a problem with GnuPG, it's rather non-standard to use "bare" files like this and it causes issues when multiple keys from GitHub are concatenated. Normally, concatenating ASCII-armored files is supposed to work but when files are taken from GitHub, the lack of trailing newline combines them into something like:
which is not valid, and causes GnuPG to silently ignore the second key.
Would it be possible to add a newline to the generated output to improve interoperability?
[EDIT: actually, I think it's in violation of RFC 4880:
]
Beta Was this translation helpful? Give feedback.
All reactions