fix: handle empty responses to HEAD requests

octokit · Apr 30, 2018 · fc800a2 · fc800a2
1 parent 522bf07
commit fc800a2
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/request/request.js b/lib/request/request.js
@@ -39,8 +39,6 @@ function request (requestOptions) {
   return fetch(requestOptions.url, pick(requestOptions, 'method', 'body', 'headers', 'timeout', 'agent'))
 
     .then(response => {
-      const contentType = response.headers.get('content-type')
-
       for (const keyAndValue of response.headers.entries()) {
         headers[keyAndValue[0]] = keyAndValue[1]
       }
@@ -49,6 +47,15 @@ function request (requestOptions) {
         return
       }
 
+      // GitHub API returns 200 for HEAD requsets
+      if (requestOptions.method === 'HEAD') {
+        if (response.status < 400) {
+          return
+        }
+
+        throw new HttpError(response.statusText, response.status, headers)
+      }
+
       if (response.status === 304) {
         requestOptions.url = response.headers.location
         throw new HttpError('Not modified', response.status, headers)
@@ -62,6 +69,7 @@ function request (requestOptions) {
           })
       }
 
+      const contentType = response.headers.get('content-type')
       if (/application\/json/.test(contentType)) {
         return response.json()
       }